Skip to contentSkip to conversation

llvm: enable LLVMgold.so build by adding binutils dependency

PATCH In review [email protected] 2 participants 5 messages Feb 23

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 llvm: enable LLVMgold.so build by adding binutils dependency

From: "mark.yang" <[email protected]>

Currently, LLVMgold.so is not built because the binutils headers are missing during the build process.

This allows LLVM to find the necessary headers and build the LLVMgold.so, which is required for Link Time Optimization (LTO) support properly.

---
v3: Ping

 meta/recipes-devtools/clang/llvm_git.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
meta/recipes-devtools/clang/llvm_git.bb +6 -1
index 96ea383731..108e884a6f 100644
@@ -11,7 +11,7 @@ require common-source.inc
 
 LIC_FILES_CHKSUM = "file://LICENSE.TXT;md5=8a15a0759ef07f2682d2ba4b893c9afe"
 
-DEPENDS = "llvm-tblgen-native libffi libxml2 zlib zstd"
+DEPENDS = "llvm-tblgen-native libffi libxml2 zlib zstd binutils"
 
 inherit cmake pkgconfig lib_package multilib_header
 
@@ -50,6 +50,7 @@ EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=MinSizeRel \
                   -DLLVM_TOOL_YAML2OBJ_BUILD=OFF \
                   -DLLVM_NATIVE_TOOL_DIR=${STAGING_BINDIR_NATIVE} \
                   -DLLVM_TABLEGEN=${STAGING_BINDIR_NATIVE}/llvm-tblgen \
+                  -DLLVM_BINUTILS_INCDIR=${STAGING_INCDIR} \
                   -DCROSS_TOOLCHAIN_FLAGS_NATIVE='-DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain-native.cmake' \
                  "
 
@@ -126,6 +127,10 @@ llvm_sysroot_preprocess() {
         install -m 0755 ${S}/llvm/tools/llvm-config/llvm-config ${SYSROOT_DESTDIR}${bindir_crossscripts}/
 }
 
+PACKAGES =+ "llvm-linker-tools"
+
+FILES:llvm-linker-tools = "${libdir}/LLVMgold* ${libdir}/libLTO.so.*"
+
 FILES:${PN}-dev += "${libdir}/llvm-config"
 
 BBCLASSEXTEND = "native nativesdk"
author
#2 lore raw

Oh, I apologize.
The patch exists in master-backlog.

#3 lore raw
In reply to [email protected]

Hi,

Quoted 10 lines · mark.yang via lists.openembedded.org

From: "mark.yang" <[email protected]>

Currently, LLVMgold.so is not built because the binutils headers are missing during the build process.

This allows LLVM to find the necessary headers and build the LLVMgold.so, which is required for Link Time Optimization (LTO) support properly.

I don't think my Signed-off-by here is appropriate as I did not sign-off this version of the patch in particular. I may have picked a previous version of this patch and applied it to my branch. But when re-sending a patch please the Signed-off-by list to your identity only.

Thanks!
Antonin

author
#4 lore raw

Dear Antonin,

Thank you. I will keep that in mind from now on!